Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing the AWS Account ID during SQS Subscribe #24

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

jameskbride
Copy link
Owner

@jameskbride jameskbride commented Jul 6, 2024

Context

This PR is the first step in fixing #25 with ListSubscriptions. When ListSubscriptions is invoked it should display ARNs for SQS subscriptions, however local-sns displays the endpoint instead. In order to fix this behavior we need to capture the AWS Account ID so that we can displays it as part of the ARN value. When an HTTP SQS endpoint subscription is created we need to capture this ID and set it as the queueOwnerAWSAccountId Camel parameter (see the docs.

Changes

  • Updated the Subscribe endpoint to capture the AWS account id for HTTP SQS endpoints, and to set it for the queueOwnerAWSAccountId parameter when creating the AWS Camel-compliant endpoint. Example: For the SQS endpoint https://sqs.us-east-1.amazonaws.com/123456789012/queue1, 123456789012 is the AWS Account ID.

Testing and Validation Steps

@jameskbride jameskbride force-pushed the sqs-subscribe-captures-the-account-id branch from c31fbe3 to 0243f74 Compare July 6, 2024 13:45
@jameskbride jameskbride merged commit 4eb2f0b into main Jul 6, 2024
1 check passed
@jameskbride jameskbride deleted the sqs-subscribe-captures-the-account-id branch July 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant